New release breaks everything

[radvil]

Seems like the neweset version breaks everything, all dependencies, options,everything.

Can you make a new branch associated to previous version before the breaking changes ??
It's so pain in the ass to re adjusting my configuration, like I dont have time.

Please make a new branch. Thanks

[radvil]

Also I got these errors

[rest.nvim] WARN: Unrecognized  configs found in setup: { "keybinds.2", "keybinds.1" }
[rest.nvim] Dependency 'lua-curl' was not found. Default HTTP client won't work
[rest.nvim] Dependency 'xml2lua' was not found. rest.nvim will be completely unable to use XML bodies in your requests
[rest.nvim] Dependency 'nvim-nio' was not found. rest.nvim will not work asynchronously
[rest.nvim] Dependency 'mimetypes' was not found. rest.nvim will  be completely unable to recognize the file type of external body files

[8uff3r]

I added the dependencies to luarocks.nvim and it's working, I use lazy.nvim so this is my config:

  {
    "vhyrro/luarocks.nvim",
    opts = {
      rocks = {  "lua-curl", "nvim-nio", "mimetypes", "xml2lua" }, -- Specify LuaRocks packages to install
    },
  }

[radvil]

Thanks, I ll try that. This should be clarified in the documentation.

[radvil]

I added the dependencies to luarocks.nvim and it's working, I use lazy.nvim so this is my config:

  {
    "vhyrro/luarocks.nvim",
    opts = {
      rocks = {  "lua-curl", "nvim-nio", "mimetypes", "xml2lua" }, -- Specify LuaRocks packages to install
    },
  }

This works, but the keybinds options seems like still broken. still have that error message, but it's fine, gotta setup them manually for now

[NTBBloodbath]

Hey, I'm very sorry that everything broke, but it was for improvement and it was necessary, nothing will break again!

Could you send your keybind setup? I'm busy right now so I can't help much, but as soon as I can I'll take a look. Also thanks @8uff3r for helping there! :)

[radvil]

Hey, I'm very sorry that everything broke, but it was for improvement and it was necessary, nothing will break again!

Could you send your keybind setup? I'm busy right now so I can't help much, but as soon as I can I'll take a look. Also thanks @8uff3r for helping there! :)

It's okay for breaking changes, I like a new result preview, however it is better to make a stable release for the previous version that doesn't break, because I needed to search to the whole commit history just to make everything works as the previous one again.

Anyway, here is my config options:

    opts = {
      client = "curl",
      env_file = ".env",
      env_pattern = "\\.env$",
      env_edit_command = "tabedit",
      encode_url = true,
      skip_ssl_verification = false,
      custom_dynamic_variables = {},
      logs = {
        level = "info",
        save = true,
      },
      highlight = {
        enable = true,
        timeout = 750,
      },
      result = {
        split = {
          in_place = false,
          horizontal = false,
          stay_in_current_window_after_split = true,
        },
        behavior = {
          decode_url = true,
          show_info = {
            url = true,
            headers = true,
            http_info = true,
            curl_command = true,
          },
          formatters = {
            json = "jq",
            html = function(body)
              if vim.fn.executable("tidy") == 0 then
                return body, { found = false, name = "tidy" }
              end
              local fmt_body = vim.fn.system({
                "tidy",
                "-i",
                "-q",
                "--tidy-mark", "no",
                "--show-body-only", "auto",
                "--show-errors", "0",
                "--show-warnings", "0",
                "-",
              }, body):gsub("\n$", "")

              return fmt_body, { found = true, name = "tidy" }
            end,
          },
        },
      },
      keybinds = {
        { "<localleader>rr", "<cmd>Rest run<cr>",      "Run request under the cursor", },
        { "<localleader>rl", "<cmd>Rest run last<cr>", "Re-run latest request", },
      }
    },

I just pasted everything from the default config based on the new README.

[radvil]

I leave this comment here, just in case anyone else that want to revert to previous version.
This is latest commit that works 91badd46c60df6bd9800c809056af2d80d33da4c

[8uff3r]

Hey, I'm very sorry that everything broke, but it was for improvement and it was necessary, nothing will break again!

Could you send your keybind setup? I'm busy right now so I can't help much, but as soon as I can I'll take a look. Also thanks @8uff3r for helping there! :)

It's okay for breaking changes, I like a new result preview, however it is better to make a stable release for the previous version that doesn't break, because I needed to search to the whole commit history just to make everything works as the previous one again.

Anyway, here is my config options:

    opts = {
      client = "curl",
      env_file = ".env",
      env_pattern = "\\.env$",
      env_edit_command = "tabedit",
      encode_url = true,
      skip_ssl_verification = false,
      custom_dynamic_variables = {},
      logs = {
        level = "info",
        save = true,
      },
      highlight = {
        enable = true,
        timeout = 750,
      },
      result = {
        split = {
          in_place = false,
          horizontal = false,
          stay_in_current_window_after_split = true,
        },
        behavior = {
          decode_url = true,
          show_info = {
            url = true,
            headers = true,
            http_info = true,
            curl_command = true,
          },
          formatters = {
            json = "jq",
            html = function(body)
              if vim.fn.executable("tidy") == 0 then
                return body, { found = false, name = "tidy" }
              end
              local fmt_body = vim.fn.system({
                "tidy",
                "-i",
                "-q",
                "--tidy-mark", "no",
                "--show-body-only", "auto",
                "--show-errors", "0",
                "--show-warnings", "0",
                "-",
              }, body):gsub("\n$", "")

              return fmt_body, { found = true, name = "tidy" }
            end,
          },
        },
      },
      keybinds = {
        { "<localleader>rr", "<cmd>Rest run<cr>",      "Run request under the cursor", },
        { "<localleader>rl", "<cmd>Rest run last<cr>", "Re-run latest request", },
      }
    },

I just pasted everything from the default config based on the new README.

You can use lazy.nvim to setup your keybinds with keys:

  {
    "rest-nvim/rest.nvim",
    keys = {
      { "<leader>rr", "<cmd>Rest run<cr>", desc = "Run REST request" },
    },
  },

[NTBBloodbath]

however it is better to make a stable release for the previous version that doesn't break, because I needed to search to the whole commit history just to make everything works as the previous one again.

In the repository there are tags and semantic releases that you can use in your plugin manager to rollback to the previous stable release :)

---

Now, that bug is a little weird, I'll definitely take a look at it as soon as I get home, thanks for reporting it and also for providing a commit in case someone wants to rollback that way, that is appreciated.

[radvil]

however it is better to make a stable release for the previous version that doesn't break, because I needed to search to the whole commit history just to make everything works as the previous one again.

In the repository there are tags and semantic releases that you can use in your plugin manager to rollback to the previous stable release :)

Now, that bug is a little weird, I'll definitely take a look at it as soon as I get home, thanks for reporting it and also for providing a commit in case someone wants to rollback that way, that is appreciated.

Oh, my bad, I didn't check the release tags, haha. Sorry for that