Feature: update required lua version up to actual 5.4

[tony-sol]

Issues

• I have checked existing issues and there are no existing ones with the same request.

Feature description

According to dependencies, rest.nvim requires "lua >= 5.1, < 5.4", but while i'm trying to use it with lua 5.3.6 it always causes an warning

`lua` version `5.1` needed, but found `Lua 5.3.6  Copyright (C) 1994-2020 Lua.org, PUC-Rio`

[boltlessengineer]

I haven't really test this plugin with lua version other than 5.1 and Neovim only supports lua 5.1 via LuaJIT (:h lua) so "lua == 5.1" might make more sense.

I guess @NTBBloodbath set it to "lua >= 5.1 < 5.4" because those lua versions are somewhat similar.

Btw the lua version 5.1 requirement is from your package manager and not from rest.nvim. You need lua 5.1 in your system to properly install this plugin via luarocks.

Both lazy.nvim and rocks.nvim should handle this lua dependency automatically.
What neovim plugin manager are you using to install rest.nvim?

Edit: correct

[tony-sol]

Both lazy.nvim and rocks.nvim should handle this lua dependency automatically. What neovim plugin manager are you using to install rest.nvim?

lazy.nvim

[boltlessengineer]

You can 1) manually install lua5.1 in your machine or 2) force lazy.nvim to use hererocks to install all lua & luarocks by itself.

For second method, your lazy.nvim setup will look like this:

require("lazy").setup({
  spec = {
    -- your plugin specs
  },
  rocks = {
    enabled = true,
    hererocks = true,
  },
})

[tony-sol]

Thx, i'll switch to 5.1, btw is 5.1.5 ok? Is it bounded only to minor version, or also to patch?

[boltlessengineer]

lua in your system is only used to install the plugin no many stuffs happening there. 5.1.5 is fine, I'm also using that version.

[dzintars]

This were no-go for me to even try this plugin.
I won't bother to downgrade Lua just because of this single plugin. This is very first plugin in my entire setup, which have this kind of issue.
v5.1 were released in 21 Feb 2006 and v5.4 were released in 29 Jun 2020.
It's a long time to ago and it is definitely time to move on.

[boltlessengineer]

@dzintars This plugin relies on lua 5.1 because that is the version Neovim is using.

Neovim only supports lua 5.1 via LuaJIT (:h lua)

You don't need to downgrade lua in your system. This plugin can work without matching lua version from system level.
Can you describe the issue while installing this plugin? So that I can help you properly.

[dzintars]

@boltlessengineer

This is the original gibberish:

This is what's on my system:

The only way to get this plugin working is something like this:

We are switching to outdated Lua 5.1 version.

Then, we need to mess up the luarocks because it complains about something something when trying to use Lua 5.1.

cd /opt/luarocks-3.11.1
./configure --with-lua-include=/opt/lua-5.1.5/src
make
sudo make install

We are explicitly pointing to the right lua.h headers there.

Only after these nasty tweaks I were able to install this plugin like a normal human being. :)

[boltlessengineer]

@dzintars glad that you were able to install the plugin at the end.

You don't need to fix lua/luarocks installation in your machine if you are using lazy.nvim.
lazy.nvim can handle those automatically.
As your first screenshot says:

• enable hererocks with opts.rocks.hererocks = true

with this option, lazy.nvim will install both lua & luarocks required to install this plugin only for Neovim, so you don't need to change system installed lua version.

[tony-sol]

The only thing i still cant understand is - if nvim uses lua5.1 "under the hood" (which is true), why plugins use a system-installed lua, instead bundled one, and why the only rest.nvim keeps complaining about lua version

[boltlessengineer]

@tony-sol It's not rest.nvim complaining about the lua version. It's luarocks which requires system installed lua5.1 to install rockspec packages.

[dzintars]

So... this plugin is using luarocks to get deps and build itself? Because Nvim runs under Lua 5.1, rest.nvim should be also built against the same Lua version (5.1)? Is this right?