Skip to content

fix: result_split_horizontal config getter#106

Merged
NTBBloodbath merged 1 commit intorest-nvim:mainfrom
ybbond:fix/split-config
May 1, 2022
Merged

fix: result_split_horizontal config getter#106
NTBBloodbath merged 1 commit intorest-nvim:mainfrom
ybbond:fix/split-config

Conversation

@ybbond
Copy link
Copy Markdown
Contributor

@ybbond ybbond commented Mar 29, 2022

Currently, the getter for config result_split_horizontal is not working because it access the config table directly.

I fixed the issue by using config.get("result_split_horizontal").

confirmed working on my machine 😃

P.S.

I have idea to add config to either show the split in the right (if vertical) or below (if horizontal). should I open issue for that?

the option is to add more config key reverse_split, or make a breaking change by deleting existing result_split_horizontal then adding:

  setup {
    -- ....
    split_position = "left", -- possible value: "top" | "right" | "bottom" | "left"
  }

@NTBBloodbath
Copy link
Copy Markdown
Member

Hi, thank you so much and I'm really sorry for the response delay!

I have idea to add config to either show the split in the right (if vertical) or below (if horizontal). should I open issue for that?

Sure thing, go ahead! :)

I don't personally like breaking changes but some of them are needed so we could use your solution for split_position key.

Cheers!

@NTBBloodbath NTBBloodbath merged commit e5f68db into rest-nvim:main May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants