fix formatter for html and error in rest.run()#165
Closed
udayvir-singh wants to merge 3 commits intorest-nvim:mainfrom
udayvir-singh:main
Closed
fix formatter for html and error in rest.run()#165udayvir-singh wants to merge 3 commits intorest-nvim:mainfrom udayvir-singh:main
udayvir-singh wants to merge 3 commits intorest-nvim:mainfrom
udayvir-singh:main
Conversation
Fixes error caused by html formatter running even when tidy is not available on the system. Also fixes docs related to disabling formatters.
Adds debug<boolean> opt in config to show optionally show debug messages. Fixes rest.run showing errors because it was passing an argument of type <boolean> to rest.run_request instead of the expected <table>.
udayvir-singh
changed the title
udayvir-singh
changed the title
Contributor
Author
|
Now this PR also fixes #165 and nasty errors on rest.run() due to incorrect handling of opts. |
ray-x
reviewed
Dec 29, 2022
Collaborator
|
you can drop the second commit. I think it's best to throw an error if tidy is not available, so nothing to change on that side, what I am curious about is why NB: Sry for the close, my browser focused the closed button before I typed Enter :s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes error caused by html formatter running even when tidy is not available on the system. Also fixes docs related to disabling formatters.
fixes #164