dont display binary outputs in answer#200
Merged
teto merged 2 commits intorest-nvim:mainfrom Jun 6, 2023
Merged
Conversation
added 2 commits
June 6, 2023 15:34
I removed some dead code and also the providing of neovim since it interfered with plugins (nixpkgs telescope required a neovim version >= 0.9).
I was testing an API that returned a zip file and it was getting out of hand so I added an is_binary_content_type to control whether to display the content type. Ideally I would have liked the display to be a default postprocess step so that it gets more generic and let the user more control but this needs deeper refactoring.
teto
force-pushed
the
dontdisplay_binary_output
branch
from
800e88e to
5ebe35f
Compare
Collaborator
Author
|
I guess we should sitll display it in case of error, aka still inline error if status is not ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing an API that returned a zip file and it was getting out of
hand so I added an is_binary_content_type to control whether to display
the content type.
Ideally I would have liked the display to be a default postprocess step so
that it gets more generic and let the user more control but this needs
deeper refactoring.