feat: show pinner while runnig request#207
Conversation
|
I confess I am not a fan of the feature, I dont have a use of it and also the spinner looks like a generic thing you would want for several plugins. Something I've wanted for a while is to provide hooks for users to plug some stuff in. In this case we could fire an event when launching a request and when finishing it. This way you could subscribe to both events to start/stop the spinner. What do you think ? |
|
Hey @teto! I do think that hooks is an awesome idea! They will allow super easy customisation and spinner definitely can be done with those. |
|
to be clear, I dont have time to implement this but as @NTBBloodbath seems to agree with the idea, I think we could merge a PR implementing that. Quickly how it could work:
If we want to support cancel events, we could do |
|
I was going through the PR list and several PRs could use the previous mechanism. I've implemented a quick draft |
|
Note for myself: perhaps this can be implemented in future versions using fidget.nvim through luarocks. |
|
Closing this PR due to the v3 release. rest.nvim now supports spinner using fidget.nvim |
|
@boltlessengineer that is a great news! Thank you |
Hey! I really enjoy using this plugin, use it almost every day.
Some queries that I run takes long time to complete. And while they are running I don't get any feedback from neovim.
Decided to add a little spinner on the line of the request so I can know that the request is running
Took an inspiration of this in https://github.com/hudclark/grpc-nvim . It is similar plugin but for grpc calls