Fix: content-type cannot be extracted from headers#255
Merged
NTBBloodbath merged 1 commit intorest-nvim:mainfrom Nov 19, 2023
Merged
Fix: content-type cannot be extracted from headers#255NTBBloodbath merged 1 commit intorest-nvim:mainfrom
NTBBloodbath merged 1 commit intorest-nvim:mainfrom
Conversation
NTBBloodbath
approved these changes
Nov 19, 2023
Member
|
Hey, thank you so much per doing this. The truth is I hadn't had enough time to deal with this and make the patch. Thank you very much for contributing and also thanks to @onns for testing the changes! Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Some related issues:
Causes
res.headersis not akey:valuetable, so it can't extract the content-type properly, as below:{ "Content-Type: application/json; charset=utf-8", "Date: Thu, 16 Nov 2023 15:54:51 GMT", "Content-Length: 614" }Fix
convert
res.headerstokey:valuetable.And, I changed
headersstructures in context:context.result.headers.Before, it was the above structure, now:
{ ["Content-Type"]: "application/json; charset=utf-8", ["Content-Length"]: "614", "Date": "Thu, 16 Nov 2023 15:54:51 GMT" }This plugin is awesome, really straightforward and user-friendly. Thanks a lot for your hard work!