prevent modified flag switch for httpResult#34
Merged
NTBBloodbath merged 1 commit intorest-nvim:mainfrom Jul 21, 2021
Merged
Conversation
Member
|
Hey, thank you for that improvement. Being honest i didn't noticed because I always do And sure, I'll do that change in a few minutes :) |
NTBBloodbath
approved these changes
Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @NTBBloodbath, currently httpResult buffer gets modified flag set to true (there is a plus sign on the statusline) if it is reused for another query. This can lead some users (like me;)) to be asked to save or discard the buffer contents. By changing the buftype option of the httpResult to nofile, makes modified flag to be ignored.
Btw. would you consider changing the stylua indentention to spaces? I think it is more common pattern both across lua neovim plugins, and more professional lua projects, see luarocks for example.