fix: correctly urlencode query parameters#354
Merged
NTBBloodbath merged 1 commit intorest-nvim:mainfrom Apr 12, 2024
flexagoon:urlencode-fix
Merged
fix: correctly urlencode query parameters#354NTBBloodbath merged 1 commit intorest-nvim:mainfrom flexagoon:urlencode-fix
NTBBloodbath merged 1 commit intorest-nvim:mainfrom
flexagoon:urlencode-fix
Conversation
NTBBloodbath
approved these changes
Apr 12, 2024
Member
NTBBloodbath
left a comment
NTBBloodbath
left a comment
There was a problem hiding this comment.
Looks good to me, thank you very much for the patch! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #317
Splits the query into individual parameters and appends each one to the url using the
U_APPENDQUERYflag. Handling of the=character is not needed due to how the flag works:See https://curl.se/libcurl/c/curl_url_set.html#CURLUAPPENDQUERY