feat: add default = true for highlight groups definition.#541
Merged
boltlessengineer merged 2 commits intorest-nvim:mainfrom Mar 8, 2025
Merged
feat: add default = true for highlight groups definition.#541boltlessengineer merged 2 commits intorest-nvim:mainfrom
boltlessengineer merged 2 commits intorest-nvim:mainfrom
Conversation
1. Add `default = true` for highlight groups, allow user to custom style. 2. Add descriptions for highlight groups in doc `rest-nvim.txt`
boltlessengineer
requested changes
Mar 6, 2025
Contributor
boltlessengineer
left a comment
boltlessengineer
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Although your documentation looks completely fine, it will be removed when auto-generating the help pages. So we should put that inside lua codes.
You can do this with docgen command.
I will modify your PR if you are not familiar with nix in this weekend.
Contributor
Author
|
Thank you for your explaination! |
boltlessengineer
approved these changes
Mar 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default = truefor highlight groups, allow user to custom style.rest-nvim.txt.