Fix date parsing bug, now timezones on all objects#296
Merged
richardpenman merged 3 commits intorichardpenman:masterfrom Oct 7, 2025
Merged
Fix date parsing bug, now timezones on all objects#296richardpenman merged 3 commits intorichardpenman:masterfrom
richardpenman merged 3 commits intorichardpenman:masterfrom
Conversation
…hing so errors like that are not hidden
Owner
|
Thanks for all this work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
def cast_datewas usingdatetime.timezone.utcwhich was wrong becausedatetimewas the object not the module. This error was caught but it meant thedp.parsepath was never running.Now that its fixed, many timestamps get parsed with a timezone attribute they didn't have before. I went ahead and made all parsing (no matter via
dp.parseordatetime_parse) to have a timezone for consistency.