Skip to content

Fix date parsing bug, now timezones on all objects#296

Merged
richardpenman merged 3 commits intorichardpenman:masterfrom
brondsem:more_date_formats
Oct 7, 2025
Merged

Fix date parsing bug, now timezones on all objects#296
richardpenman merged 3 commits intorichardpenman:masterfrom
brondsem:more_date_formats

Conversation

@brondsem
Copy link
Copy Markdown
Contributor

@brondsem brondsem commented Oct 6, 2025

def cast_date was using datetime.timezone.utc which was wrong because datetime was the object not the module. This error was caught but it meant the dp.parse path was never running.

Now that its fixed, many timestamps get parsed with a timezone attribute they didn't have before. I went ahead and made all parsing (no matter via dp.parse or datetime_parse) to have a timezone for consistency.

@richardpenman
Copy link
Copy Markdown
Owner

Thanks for all this work!

@richardpenman richardpenman merged commit 63d8c01 into richardpenman:master Oct 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants