Feature: Add Dual-Stack support with IPv6 preference#309
Merged
richardpenman merged 1 commit intorichardpenman:masterfrom Jan 9, 2026
Merged
Feature: Add Dual-Stack support with IPv6 preference#309richardpenman merged 1 commit intorichardpenman:masterfrom
richardpenman merged 1 commit intorichardpenman:masterfrom
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modernizes the NICClient network logic by introducing Dual-Stack (IPv4/IPv6) support.
Previously, the library was forced to use
socket.AF_INET(IPv4), making it unable to connect to WHOIS servers over IPv6 or leverage IPv6-only environments.The core of this change is a refactoring of the connection logic into a centralized _connect method that uses
socket.getaddrinfowithsocket.AF_UNSPEC.Key Changes
_connect(hostname, timeout)to handle DNS resolution and connection attempts. This replaces the scatteredget_socket()+connect()calls inwhois()andfindwhois_iana().prefer_ipv6toggle inNICClient.__init__. When enabled, the client sorts resolved addresses to prioritizeAF_INET6(IPv6) overAF_INET(IPv4).--prefer-ipv6flag to the command-line interface.