Fix 4819 by modifying the id of the outer FieldComponent render#4823
Merged
heath-freenome merged 1 commit intorjsf-team:mainfrom Oct 29, 2025
Merged
Fix 4819 by modifying the id of the outer FieldComponent render#4823heath-freenome merged 1 commit intorjsf-team:mainfrom
heath-freenome merged 1 commit intorjsf-team:mainfrom
Conversation
nickgros
approved these changes
Oct 29, 2025
Fixed rjsf-team#4819 by modifying the id for the outer `FieldComponent` render when a `XxxOfField` component is also being rendered - In `@rjsf/core`, updated `SchemaField` to add a new optional property `childFieldPathId` to the `FieldComponent` render to prevent duplicate ids - Also updated `ObjectField` and `ArrayField` to make children use the `childFieldPathId` if present, falling back to the `fieldPathId` if not - Fixed the places in the `XxxOf` tests where the new outer id changed the `description` ids the test was looking for - Updated `CHANGELOG.md` accordingly # Conflicts: # CHANGELOG.md
heath-freenome
force-pushed
the
fix-4819
branch
from
abb789c to
7f0c1e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixed #4819 by modifying the id for the outer
FieldComponentrender when aXxxOfFieldcomponent is also being rendered@rjsf/core, updatedSchemaFieldto add a new optional propertychildFieldPathIdto theFieldComponentrender to prevent duplicate idsObjectFieldandArrayFieldto make children use thechildFieldPathIdif present, falling back to thefieldPathIdif notXxxOftests where the new outer id changed thedescriptionids the test was looking forCHANGELOG.mdaccordinglyChecklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.