Old packages won't install ('invalid filename' error)

[josephg]

Using master of sinopia:

Client:

$ npm install thirty-two --registry=http://localhost:4873/
npm http GET http://localhost:4873/thirty-two
npm http 200 http://localhost:4873/thirty-two
npm http GET http://localhost:4873/thirty-two/-/thirty-two@0.0.1.tgz
npm http 403 http://localhost:4873/thirty-two/-/thirty-two@0.0.1.tgz
npm ERR! fetch failed http://localhost:4873/thirty-two/-/thirty-two@0.0.1.tgz
npm ERR! Error: 403 Forbidden
...
npm ERR! npm -v 1.4.3

Server:

$ bin/sinopia 
 warn  --- Server is listening on http://localhost:4873/
 http  <-- 304, user: undefined, req: 'GET /thirty-two', bytes: 0/0
 http  <-- 403, user: undefined, req: 'GET /thirty-two/-/thirty-two@0.0.1.tgz', error: invalid filename

[josephg]

The problem is that thirty-two was published 3 years ago, and apparently npm used to have a different tarball naming system.

in utils.js's validate_name it checks for name.match(/[\/@\s\+%:]/), and the tarball file for thirty-two contains an @ - its thirty-two@0.0.1.tgz. Newer packages use a dash instead: livedb-mongo-0.3.2.tgz.

I'm happy to submit a PR to fix this - what would be the best way?

[rlidwka]

Thanks, should work now. Also, I've changed that regexp so names won't have arbitrary unicode in them (encodeURIComponent used to take care of that before).

(and sorry for answering late, was on vacation)

[josephg]

Its cool - I know how it goes. Thanks!