Skip to content

web-gui/updating entries shown on index page#143

Merged
rlidwka merged 1 commit intorlidwka:masterfrom
vernak2539:web-gui-proper-index-versions
Oct 17, 2014
Merged

web-gui/updating entries shown on index page#143
rlidwka merged 1 commit intorlidwka:masterfrom
vernak2539:web-gui-proper-index-versions

Conversation

@vernak2539
Copy link
Copy Markdown
Contributor

utils.semver_sort will put the put the package's dist-tags in order from least to greatest (if that makes sense for semver). Taking the first index of the array will always return the lowest semver, and we want to display the latest/highest version on initial load (using .pop())

@vernak2539
Copy link
Copy Markdown
Contributor Author

@rlidwka is this not the correct approach? Just want to get this in so we can use it

rlidwka added a commit that referenced this pull request Oct 17, 2014
web-gui/updating entries shown on index page
@rlidwka rlidwka merged commit a1010be into rlidwka:master Oct 17, 2014
@rlidwka
Copy link
Copy Markdown
Owner

rlidwka commented Oct 17, 2014

Yes, you're right.

Sorry for the delayed response, I'll try to be a bit faster in the future.

@vernak2539 vernak2539 deleted the web-gui-proper-index-versions branch October 17, 2014 13:52
@vernak2539
Copy link
Copy Markdown
Contributor Author

No worries. Thanks!

@rlidwka rlidwka mentioned this pull request Nov 11, 2014
rmg pushed a commit to strongloop-forks/sinopia that referenced this pull request Jun 1, 2017
Allow configuring a tagline that is displayed on the webpage between …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants