This repository was archived by the owner on Feb 4, 2022. It is now read-only.
Let users use a custom merge function#292
Open
lopugit wants to merge 4 commits intorobinvdvleuten:masterfrom
Open
Let users use a custom merge function#292lopugit wants to merge 4 commits intorobinvdvleuten:masterfrom
lopugit wants to merge 4 commits intorobinvdvleuten:masterfrom
Conversation
Owner
|
@lopugit thank you for your PR! Can you add a testcase? |
Author
Sure thing |
|
Hi @lopugit, what is an update on this? I found what you did here really useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Let's a user pass a custom merging function
Why: Because current deepmerge library doesn't support circular object merging and in the case someone wants to use their own merging strategy it isn't possible regardless
How: Forked the master branch and made the simple changes
Checklist: