This repository was archived by the owner on Feb 4, 2022. It is now read-only.
Add string type of header check#402
Open
iliapisaniy wants to merge 1 commit intorobinvdvleuten:masterfrom
iliapisaniy:add-header-check-on-readme-nuxt
Open
Add string type of header check#402iliapisaniy wants to merge 1 commit intorobinvdvleuten:masterfrom iliapisaniy:add-header-check-on-readme-nuxt
iliapisaniy wants to merge 1 commit intorobinvdvleuten:masterfrom
iliapisaniy:add-header-check-on-readme-nuxt
Conversation
|
I Approve, It works |
Owner
|
Can you explain what you are trying to achieve here? |
|
when using it in conjuction with the cookie package in a project with nuxt ssr the first time it runs the plugin mentioned in the readme file throws an error because the req.headers.cookie is undefined, that cuses that the cookie.parse function throws an error since it is expecting a string not an undefined. I solved by just adding
that produces the same result as the solution in this request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Bug in case of using nuxt ssr plugin from
readmeWhy:
How: Check type of cookie header and set to string if not
Checklist:
Issue #398