Type definitions for react-fela

[marcneander]

Type definitions for react-fela is completely broken and should probably be removed or fixed.

Unfortunately I don't have enough experience with Typescript yet to fix this myself.

[tomwagner]

Maybe it's related with #677. From my point of view in my usage the TS typings looks good. Try to be more specific.

[marcneander]

I'm on my phone right now but here's a small list from the top of my head.

• useFela hook is not defined
• createComponent with ':hover' and other psuedo classes not compatible if not first argument is a function.
• createComponent with another component in second argument seems to be completely missing.

Probably more...

[reinhard]

I would not call the typescript support of Fela 'completelty broken' either. createComponent should not be used any longer (AFAIU it will or already is deprectated).

For useFela I created a pull request at #683

Also see https://github.com/Indoqa/indoqa-react/blob/feature/theming-v2/packages/style-system-demo/src/main/fela/FelaComponentSamples.tsx and https://github.com/Indoqa/indoqa-react/blob/feature/theming-v2/packages/style-system-demo/src/main/fela/FelaHookSamples.tsx (FelaHookSamples require #683 to be merged into Fela though)

[robinweser]

Anything else to add here? I only accept PRs for TypeScript stuff, will never fix that on my own :P

[reinhard]

Nothing from me.

[marcneander]

@reinhard Your PR from yesterday is incorrect and does not let typescript users add arguments to useFela. This is why this issue is here. We don't have ThemeContext definitions either.

I see two solutions:

• Test the type definitions here in the fela monorepo.
• Move definitions to https://github.com/DefinitelyTyped and let the community handle it.

Overriding type definitions from the installed package itself is messy, especially with CRA --typescript. I would love to see solution nr 2.

[TxHawks]

+1 for DefinitelyTyped. Since we don't really maintain the TS definitions, I see no added value in maintaining them here

[robinweser]

@marcneander Feel free to organize the migration to DefinitelyTyped. I would love to see that being improved in the future!

[marcneander]

I'd love to but I already have too much on my table right now. If this is still an issue after summer I'll make the effort 👍

[UberMouse]

I've created a PR to fix the specific issue introduced in #677 in #692

[robinweser]

So ill close this issue now. If there're still any issues, feel free to reopen or open a new one.