Incorrect output from generateFontSource()

[layershifter]

Type: Bug

Pass localAlias option to renderFont and you will get weird output:

@font-face {
  font-weight: 400;
  src: {src} /* <---- ???????? */ local('Segoe WP Light'), url('...') format('woff2');
  font-family:"Segoe UI"
}

Packages	Version
fela	10.4.1

Description

Issue comes from broken template string in generateFontSource():

-return `{src} local(${localUrl}), `
+return `${src} local(${localUrl}), `

[robinweser]

Huh, when was this once introduced :o
Will fix asap!

[layershifter]

Actually I started to work on it 🐎 But, feel free to make PR 🐱

There is one more issue: files and fontLocals are optional params, so I can pass empty array of files (it's our usecase).

After this fix it will receive:

@font-face {
  font-weight: 400;
  src: local('Segoe WP Light'), local('Segoe WP'), ; /* <-- lonely comma 🐗  */
  font-family: "Segoe UI"
}

[robinweser]

Oh if you wanna fix it, go for it :)
I never really touched the font loading for 2 years now.

[layershifter]

Fix in #710 🚀