Skip to content

pass theme with props when using useFela#669

Merged
robinweser merged 1 commit intomasterfrom
useFela-props-with-theme
Feb 12, 2019
Merged

pass theme with props when using useFela#669
robinweser merged 1 commit intomasterfrom
useFela-props-with-theme

Conversation

@robinweser
Copy link
Copy Markdown
Owner

@robinweser robinweser commented Feb 11, 2019

Description

Passes the theme to props as well when using useFela together with rules.

Packages

List all packages that have been changed.

  • react-fela

Versioning

I consider it a patch even though it might be considered Minor Major. The reason is that I believe it is a bug at first hand and should have been there all the time.

  • Major
  • Minor
  • Patch

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

@robinweser robinweser requested a review from TxHawks February 11, 2019 08:32
@robinweser robinweser merged commit 628fc55 into master Feb 12, 2019
@robinweser robinweser deleted the useFela-props-with-theme branch February 12, 2019 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant