Merged
Conversation
… style functions 1. Instead of checking the type of `render` to determine if it should be converted to an `as` or to children, which is problematic when the value of render is a variable, simply check if the `FelaComponent` has children, which is both simpler and should be more robust. 2. Limit the conversion scope of function arguments in the `style` prop to only affect the outer-most instance, so that if a callback is used inside the style object, it is not affected. 3. For completeness, in addition to arrow functions, also convert function expressions in the `style` prop (though, they are converted to arrow functions, so may potetially still cause bugs, so print a warning) 4. Print a warning when `style` is a reference to an external variable that cannont be validated and converted fixes #672
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of checking the type of
renderto determine if it should beconverted to an
asor to children, which is problematic when the value ofrender is a variable, simply check if the
FelaComponenthas children,which is both simpler and should be more robust.
Limit the conversion scope of function arguments in the
styleprop to onlyaffect the outer-most instance, so that if a callback is used inside the
style object, it is not affected.
For completeness, in addition to arrow functions, also convert function
expressions in the
styleprop (though, they are converted to arrowfunctions, so may potetially still cause bugs, so print a warning)
Print a warning when
styleis a reference to an external variablethat cannot be validated and converted
fixes #672
Packages
fela-codemods
Versioning
Patch
Checklist
Quality Assurance
yarn run format)yarn run lint)yarn run test)yarn run flow)Changes
If one of the following checks doesn't make sense due to the type of PR, just check them.