Skip to content

implement returning style object for native renderer #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinweser merged 1 commit into from
Feb 12, 2020
Merged

implement returning style object for native renderer #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/fela-bindings/src/FelaComponentFactory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,28 @@ export default function FelaComponentFactory(

return createElement(FelaTheme, undefined, theme => {
// TODO: could optimize perf by not calling combineRules if not necessary
const className = renderer.renderRule(combineRules(style), {
const renderedRule = renderer.renderRule(combineRules(style), {
...otherProps,
theme,
})

if (children instanceof Function) {
return children({
className,
className: !renderer.isNativeRenderer && renderedRule,
style: renderer.isNativeRenderer && renderedRule,
theme,
as,
})
}

return createElement(as, { className }, children)
return createElement(
as,
{
className: !renderer.isNativeRenderer && renderedRule,
style: renderer.isNativeRenderer && renderedRule,
},
children
)
})
}

Expand Down
⚡