Skip to content

Add ThemeContext to TypeScript typedef#776

Merged
robinweser merged 1 commit intorobinweser:masterfrom
Korzun:feature/theme-context-in-typescript-typedef
Apr 16, 2020
Merged

Add ThemeContext to TypeScript typedef#776
robinweser merged 1 commit intorobinweser:masterfrom
Korzun:feature/theme-context-in-typescript-typedef

Conversation

@Korzun
Copy link
Copy Markdown
Contributor

@Korzun Korzun commented Apr 8, 2020

Description

Adds ThemeProvider export to the react-fela TypeScript typedef; it already appears in index.js.

The index.d.ts's ThemeProviderProps and FelaThemeProps definitions both reference a Theme as having the type object, I maintained that choice.

Example

TypeScript Error

TypeScript Error

index.js

JavaScript Index File

Packages

  • react-fela

Versioning

Patch

Checklist

Quality Assurance

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

@Korzun
Copy link
Copy Markdown
Contributor Author

Korzun commented Apr 8, 2020

Mentioned in #757 (comment)

@robinweser
Copy link
Copy Markdown
Owner

Thank you!

@robinweser robinweser merged commit 2b31e80 into robinweser:master Apr 16, 2020
@Korzun Korzun deleted the feature/theme-context-in-typescript-typedef branch April 19, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants