Skip to content

Allow null in url strings#782

Merged
robinweser merged 1 commit intomasterfrom
allow-null-in-url
Apr 16, 2020
Merged

Allow null in url strings#782
robinweser merged 1 commit intomasterfrom
allow-null-in-url

Conversation

@robinweser
Copy link
Copy Markdown
Owner

@robinweser robinweser commented Apr 16, 2020

Description

This PR adds a special check for url() values since null and undefined could potentially be part of a Base64 string as seen in #772.

Packages

List all packages that have been changed.

  • fela-utils

Versioning

Patch

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

@robinweser robinweser merged commit 54053a2 into master Apr 16, 2020
@robinweser robinweser deleted the allow-null-in-url branch April 16, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant