Skip to content

Removes all references to ie_mob #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinweser merged 1 commit into from
Mar 23, 2020
Merged

Removes all references to ie_mob #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmark/packages/205/plugins/flexboxIE.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function flexboxIE(_ref) {
var css = _ref.prefix.css;
var keepUnprefixed = _ref.keepUnprefixed;

if ((alternativeProps[property] || property === 'display' && typeof value === 'string' && value.indexOf('flex') > -1) && (browser === 'ie_mob' || browser === 'ie') && version == 10) {
if ((alternativeProps[property] || property === 'display' && typeof value === 'string' && value.indexOf('flex') > -1) && browser === 'ie' && version == 10) {
if (!keepUnprefixed && !Array.isArray(styles[property])) {
delete styles[property];
}
Expand Down
2 changes: 1 addition & 1 deletion benchmark/packages/300/dynamic/plugins/flexboxIE.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function flexboxIE(property, value, style, _ref) {
keepUnprefixed = _ref.keepUnprefixed,
requiresPrefix = _ref.requiresPrefix;

if ((alternativeProps[property] || property === 'display' && typeof value === 'string' && value.indexOf('flex') > -1) && (browserName === 'ie_mob' || browserName === 'ie') && browserVersion === 10) {
if ((alternativeProps[property] || property === 'display' && typeof value === 'string' && value.indexOf('flex') > -1) && browserName === 'ie' && browserVersion === 10) {
delete requiresPrefix[property];

if (!keepUnprefixed && !Array.isArray(style[property])) {
Expand Down
2 changes: 1 addition & 1 deletion benchmark/packages/301/dynamic/plugins/flexboxIE.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function flexboxIE(property, value, style, _ref) {
keepUnprefixed = _ref.keepUnprefixed,
requiresPrefix = _ref.requiresPrefix;

if ((alternativeProps.hasOwnProperty(property) || property === 'display' && typeof value === 'string' && value.indexOf('flex') > -1) && (browserName === 'ie_mob' || browserName === 'ie') && browserVersion === 10) {
if ((alternativeProps.hasOwnProperty(property) || property === 'display' && typeof value === 'string' && value.indexOf('flex') > -1) && browserName === 'ie' && browserVersion === 10) {
delete requiresPrefix[property];

if (!keepUnprefixed && !Array.isArray(style[property])) {
Expand Down
2 changes: 1 addition & 1 deletion benchmark/packages/302/dynamic/plugins/flexboxIE.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function flexboxIE(property, value, style, _ref) {
keepUnprefixed = _ref.keepUnprefixed,
requiresPrefix = _ref.requiresPrefix;

if ((alternativeProps.hasOwnProperty(property) || property === 'display' && typeof value === 'string' && value.indexOf('flex') > -1) && (browserName === 'ie_mob' || browserName === 'ie') && browserVersion === 10) {
if ((alternativeProps.hasOwnProperty(property) || property === 'display' && typeof value === 'string' && value.indexOf('flex') > -1) && browserName === 'ie' && browserVersion === 10) {
delete requiresPrefix[property];

if (!keepUnprefixed && !Array.isArray(style[property])) {
Expand Down
1 change: 0 additions & 1 deletion docs/api/generator/generateData.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ const browserList = {
ios_saf: 8,
safari: 8,
ie: 11,
ie_mob: 11,
edge: 12,
opera: 16,
op_mini: 12,
Expand Down
1 change: 0 additions & 1 deletion docs/guides/CustomPrefixer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ const browserList = {
ios_saf: 8,
safari: 8,
ie: 11,
ie_mob: 11,
edge: 12,
opera: 16,
op_mini: 12,
Expand Down
1 change: 0 additions & 1 deletion generateDefaultData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ const defaultBrowserSupport = {
ios_saf: 9,
safari: 9,
ie: 11,
ie_mob: 11,
edge: 12,
opera: 30,
op_mini: 12,
Expand Down
2 changes: 0 additions & 2 deletions modules/__tests__/createPrefixer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ const browserList = {
ios_saf: 0,
safari: 0,
ie: 0,
ie_mob: 0,
edge: 0,
opera: 0,
op_mini: 0,
Expand Down Expand Up @@ -346,7 +345,6 @@ describe('Static Prefixer', () => {
const input = { writingMode: 'horizontal-tb' }
const output = {
WebkitWritingMode: 'horizontal-tb',
msWritingMode: 'horizontal-tb',
Copy link
Copy Markdown
Contributor Author

@outoftime outoftime Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to caniuse-api, only ie_mob needed the -ms- vendor prefix:

> caniuse.getSupport('writing-mode')
{
  and_chr: { y: 66 },
  and_ff: { y: 57 },
  and_qq: { y: 1.2, x: 1.2 },
  and_uc: { y: 11.8 },
  android: { y: 3, x: 4.4, n: 2.3 },
  baidu: { y: 7.12 },
  chrome: { n: 6, u: 7, y: 8, x: 47 },
  edge: { y: 12 },
  firefox: { n: 40, y: 41 },
  ie: { a: 11 },
  ie_mob: { a: 11, x: 11 },
  ios_saf: { y: 5, x: 10.3, u: 4.2 },
  op_mini: {},
  op_mob: { n: 12.1, y: 37 },
  opera: { n: 12.1, y: 15, x: 34 },
  safari: { n: 4, u: 5, y: 5.1, x: 10.1 },
  samsung: { y: 4, x: 4 }
}

writingMode: 'horizontal-tb',
}
expect(prefix(input)).toEqual(output)
Expand Down
1 change: 0 additions & 1 deletion modules/generator/generatePrefixMap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ const prefixBrowserMap = {
and_chr: 'Webkit',
and_uc: 'Webkit',
op_mini: 'Webkit',
ie_mob: 'ms',
}

// remove flexprops from IE
Expand Down
3 changes: 0 additions & 3 deletions modules/generator/maps/pluginMap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ export default {
opera: 16,
},
flexboxIE: {
ie_mob: 11,
ie: 11,
},
flexboxOld: {
Expand All @@ -66,7 +65,6 @@ export default {
grid: {
edge: 16,
ie: 11,
ie_mob: 11,
},
imageSet: {
chrome: maximumVersion,
Expand Down Expand Up @@ -103,7 +101,6 @@ export default {
and_uc: maximumVersion,
ios_saf: maximumVersion,
msie: maximumVersion,
ie_mob: maximumVersion,
edge: maximumVersion,
firefox: maximumVersion,
op_mini: maximumVersion,
Expand Down
⚡