Skip to content

added dagana#23

Merged
stephane-caron merged 3 commits into
robot-descriptions:mainfrom
torydebra:dagana
Apr 13, 2026
Merged

added dagana#23
stephane-caron merged 3 commits into
robot-descriptions:mainfrom
torydebra:dagana

Conversation

@torydebra

Copy link
Copy Markdown
Contributor

No description provided.

@stephane-caron

Copy link
Copy Markdown
Member

Thank you for opening this PR 👍

The new line says the license is Apache 2.0, but the linked repository does not contain a LICENSE file and the package.xml next to the description file says <license>TODO</license>. This is something that can be addressed upstream in the repository (if you are not a maintainer there, even opening an issue asking them to add a LICENSE file can help). Alternatively, we could put a ✖ in the License column here, but it might be too strong a signal for what may be just an oversight.

After the license is clarified, we can go ahead and add it to the list 👌

@torydebra

Copy link
Copy Markdown
Contributor Author

Hi,

Yes you are right, I added the correct Apache 2.0 in the upstream repo
Thanks for spotting it, and for maintaining such list

@stephane-caron stephane-caron merged commit d04c4fd into robot-descriptions:main Apr 13, 2026
1 check passed
@stephane-caron

Copy link
Copy Markdown
Member

Perfect, thank you for this addition to the list 👍

@torydebra torydebra deleted the dagana branch April 14, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants