Use typed exposed item targets#9640
Draft
rtfeldman wants to merge 1 commit into
Draft
Conversation
rtfeldman
force-pushed
the
rtfeldman/fix-exposed-item-targets-9638
branch
from
d249952 to
b59dec6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9638 by replacing ExposedItems' numeric node-index payload and unresolved 0 sentinel with explicit unresolved, value definition, and type declaration targets. Import resolution and downstream consumers now ask for the target kind they actually need, so an unresolved exposed value cannot be mistaken for a valid external definition node; the regression covers a module exposing bare f while only defining T.f.