Removes all references to ie_mob#192
Merged
robinweser merged 1 commit intorobinweser:masterfrom Mar 23, 2020
Merged
Conversation
outoftime
commented
Mar 4, 2020
| const input = { writingMode: 'horizontal-tb' } | ||
| const output = { | ||
| WebkitWritingMode: 'horizontal-tb', | ||
| msWritingMode: 'horizontal-tb', |
Contributor
Author
There was a problem hiding this comment.
According to caniuse-api, only ie_mob needed the -ms- vendor prefix:
> caniuse.getSupport('writing-mode')
{
and_chr: { y: 66 },
and_ff: { y: 57 },
and_qq: { y: 1.2, x: 1.2 },
and_uc: { y: 11.8 },
android: { y: 3, x: 4.4, n: 2.3 },
baidu: { y: 7.12 },
chrome: { n: 6, u: 7, y: 8, x: 47 },
edge: { y: 12 },
firefox: { n: 40, y: 41 },
ie: { a: 11 },
ie_mob: { a: 11, x: 11 },
ios_saf: { y: 5, x: 10.3, u: 4.2 },
op_mini: {},
op_mob: { n: 12.1, y: 37 },
opera: { n: 12.1, y: 15, x: 34 },
safari: { n: 4, u: 5, y: 5.1, x: 10.1 },
samsung: { y: 4, x: 4 }
}
Contributor
Author
|
Hey @robinweser is this good to merge? |
Owner
|
Yeah, I'm about to do that asap! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ie_mobhas been marked as a dead browser bybrowserslistand is thus no longer returned incaniuse-apiqueries when it depends on latestbrowserslist.This pull request removes all references to
ie_mobfrom the codebase and documentation.Fixes #191