feat(multi-entry)!: ensure deterministic order#1879
Merged
shellscape merged 3 commits intorollup:masterfrom Oct 4, 2025
Merged
feat(multi-entry)!: ensure deterministic order#1879shellscape merged 3 commits intorollup:masterfrom
shellscape merged 3 commits intorollup:masterfrom
Conversation
GauBen
changed the title
shellscape
changed the title
Collaborator
|
@GauBen sounds like a reasonable change to me. I see no reason why we can't just make this a major version. |
shellscape
changed the title
shellscape
changed the title
kr8n3r
added a commit
to alphagov/notifications-admin
that referenced
this pull request
Apr 21, 2026
Plugin-multi-entry introduced a breaking change in v7 of always creating a deterministic output which uses sort() - rollup/plugins#1879 For the legacy bundle, we need the order of dependencies to be fixed. Instead of continuing to use this dependency, we have our own "plugin" which concatenates those files. In the build, we make sure that `this` means `window` context and that the file as before.
kr8n3r
added a commit
to alphagov/notifications-admin
that referenced
this pull request
Apr 24, 2026
Plugin-multi-entry introduced a breaking change in v7 of always creating a deterministic output which uses sort() - rollup/plugins#1879 For the legacy bundle, we need the order of dependencies to be fixed. Instead of continuing to use this dependency, we have our own "plugin" which concatenates those files. In the build, we make sure that `this` means `window` context and that the file as before. Async load suggestion by @tombye
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
multi-entryThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Not sure if this is a fix or a feature (it's both), but files are not deterministically sorted on all platforms (when caps are involved for instance).
This PR sorts the files with JS
.sort(), which is deterministic. We cannot use.toSorted()as the plugin should work with Node 14+ (available in Node 20+).This is not technically a breaking change, because the order is currently undefined, but I get why this might be refused for a minor release.
This can also be added as an option, tell me if it is more sensible