Add a max_num_saved parameter to pointcloud_to_pcd.#127
Closed
bhaskara wants to merge 1 commit intoros-perception:kinetic-develfrom
Closed
Add a max_num_saved parameter to pointcloud_to_pcd.#127bhaskara wants to merge 1 commit intoros-perception:kinetic-develfrom
bhaskara wants to merge 1 commit intoros-perception:kinetic-develfrom
Conversation
SteveMacenski
requested changes
Oct 16, 2019
| if ((max_num_saved_ > 0) && (max_num_saved_ <= num_saved_)) | ||
| { | ||
| ROS_INFO_STREAM("Saved max number of clouds (you can quit now)"); | ||
| return; |
Member
There was a problem hiding this comment.
Is this something you'd still like merged? Looks fine to me, but I'd like after the log statement for the program to cleanly shutdown. If its done, is should be done.
Let me know if this isn't something you care for anymore and we can close the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.