Add *.razor file glob to HTML [EASY MERGE]#2115
Merged
tancnle merged 2 commits intorouge-ruby:masterfrom Apr 11, 2025
Inspirateur:master
Merged
Add *.razor file glob to HTML [EASY MERGE]#2115tancnle merged 2 commits intorouge-ruby:masterfrom Inspirateur:master
tancnle merged 2 commits intorouge-ruby:masterfrom
Inspirateur:master
Conversation
added .razor files to html lexer
added razor files to html spec
Inspirateur
changed the title
Contributor
Author
|
Should the maintainer role be passed on ? No interaction on such a low hanging fruit is somewhat concerning when this library is used by big projects such as GitLab :/ |
Collaborator
|
@Inspirateur Thank you for your contribution. This was slipped out of my radar. LGTM 🚀 |
Contributor
Author
|
phew, that's reassuring :) Thank you ! |
Contributor
Author
|
When can we expect a release that includes this change ? 🥺 I think we need it for Gitlab to pick it up. |
Collaborator
|
I will cut a release sometime this week. |
Contributor
Author
Can I expect a release today then 👀 ? Thanks for your work. |
xaviermignot
pushed a commit
to xaviermignot/rouge
that referenced
this pull request
Jun 17, 2025
* Update html.rb added .razor files to html lexer * Update html_spec.rb added razor files to html spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy of #1522 but for .razor files which are basically the successor of .cshtml files and use roughly the same syntax (see https://stackoverflow.com/a/56271408/8915326)
Using HTML syntax highlighting on .razor files will already be MUCH better than having no syntax highlighting at all.
I came here after reading this Gitlab issue https://gitlab.com/gitlab-org/gitlab-foss/-/issues/42855 we don't have hightlighting on .razor files on Gitlab because of this :)