Skip to content

Add Ruby 3.4 to CI build#2127

Merged
tancnle merged 1 commit intorouge-ruby:masterfrom
tancnle:ruby-3.4.3
May 4, 2025
Merged

Add Ruby 3.4 to CI build#2127
tancnle merged 1 commit intorouge-ruby:masterfrom
tancnle:ruby-3.4.3

Conversation

@tancnle
Copy link
Copy Markdown
Collaborator

@tancnle tancnle commented May 3, 2025

No description provided.

@tancnle tancnle added this pull request to the merge queue May 4, 2025
Merged via the queue into rouge-ruby:master with commit 4f6bf05 May 4, 2025
9 checks passed
@tancnle tancnle deleted the ruby-3.4.3 branch May 4, 2025 07:20
xaviermignot pushed a commit to xaviermignot/rouge that referenced this pull request Jun 17, 2025
@jneen
Copy link
Copy Markdown
Member

jneen commented Feb 2, 2026

@tancnle is there a reason for the mutex_m dependency here? It doesn't seem like it's used directly in the codebase

@tancnle
Copy link
Copy Markdown
Collaborator Author

tancnle commented Feb 3, 2026

@jneen I might have picked this up with an old version of minitest (related issue). I can't see the error on v6.0.1 now.

We can update minitest requirement to something like the following.

gem 'minitest', '>= 6.0'

WDYT?

@jneen
Copy link
Copy Markdown
Member

jneen commented Feb 4, 2026

Upgrading minitest seems like an easy win as long as the specs still work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants