Skip to content

Update Docker file name patterns#2133

Merged
tancnle merged 1 commit intorouge-ruby:masterfrom
oatovar:patch-1
May 28, 2025
Merged

Update Docker file name patterns#2133
tancnle merged 1 commit intorouge-ruby:masterfrom
oatovar:patch-1

Conversation

@oatovar
Copy link
Copy Markdown
Contributor

@oatovar oatovar commented May 21, 2025

The Dockerfile.* pattern is a common naming scheme when there's more than one file in a repository. Similarly, this can also be extended to Containerfile.* files. You can see this in this build-images project, and most projects under the security-products group.

The `Dockerfile.*` pattern is a common naming scheme when there's more than one file in a repository. Similarly, this can also be extended to `Containfile.*` files.
@oatovar oatovar marked this pull request as ready for review May 21, 2025 19:45
@oatovar
Copy link
Copy Markdown
Contributor Author

oatovar commented May 21, 2025

@tancnle Could you do this review? 😄

@tancnle tancnle self-assigned this May 27, 2025
@tancnle
Copy link
Copy Markdown
Collaborator

tancnle commented May 28, 2025

Thanks @oatovar. The PR LGTM 👍🏼

❯ ./bin/rougify guess Dockerfile.foo
{ tag: "docker", title: "Docker", desc: "Dockerfile syntax" }

On a side note, it seems that GitLab already detects the correct syntax (example) 🤔

@tancnle tancnle added this pull request to the merge queue May 28, 2025
Merged via the queue into rouge-ruby:master with commit d43b445 May 28, 2025
9 checks passed
@oatovar
Copy link
Copy Markdown
Contributor Author

oatovar commented May 28, 2025

@tancnle I achieved that one with a custom .gitattributes 😅 Thank you for merging this!

xaviermignot pushed a commit to xaviermignot/rouge that referenced this pull request Jun 17, 2025
The `Dockerfile.*` pattern is a common naming scheme when there's more than one file in a repository. Similarly, this can also be extended to `Containfile.*` files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants