Fix the broken Gherkin spec on main, and refactor STEP_REGEX#2226
Merged
Fix the broken Gherkin spec on main, and refactor STEP_REGEX#2226
Conversation
added 2 commits
February 26, 2026 11:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the matched
Keywordtoken from the step keywords contained spaces, which is a bug we seem to have specced in.Here I've fixed the specs, as well as pre-computed the STEP_REGEX to live in a constant in
gherkin/keywords.rb, instead of using Regex.escape and join at runtime.