Skip to content

Ensure rake check:style lints the same files as standard RuboCop runs#2237

Merged
jneen merged 1 commit intorouge-ruby:mainfrom
larouxn:rake_style_force_exclusion
Feb 27, 2026
Merged

Ensure rake check:style lints the same files as standard RuboCop runs#2237
jneen merged 1 commit intorouge-ruby:mainfrom
larouxn:rake_style_force_exclusion

Conversation

@larouxn
Copy link
Copy Markdown
Contributor

@larouxn larouxn commented Feb 27, 2026

Proposing we removed task.patterns from the rake style task so that it behaves and lints the exact same as standard bundle exec rubocop runs.

References and prior PRs

Screenshot From 2026-02-27 14-19-15

@larouxn larouxn mentioned this pull request Feb 27, 2026
@jneen
Copy link
Copy Markdown
Member

jneen commented Feb 27, 2026

Would leaving off task.patterns entirely work here?

@larouxn
Copy link
Copy Markdown
Contributor Author

larouxn commented Feb 27, 2026

Yep and in that case the exact number of files checked becomes the same too.

image

@larouxn larouxn changed the title Ensure style rake excludes them same files as standard RuboCop runs Ensure rake check:style lints the same files as standard RuboCop runs Feb 27, 2026
@larouxn larouxn force-pushed the rake_style_force_exclusion branch from b6a070b to 972d14a Compare February 27, 2026 19:21
@jneen
Copy link
Copy Markdown
Member

jneen commented Feb 27, 2026

Sweet, let's do that then. Ideally rake check:style and rubocop are identical, I don't think there's any reason for them to be different.

@jneen jneen added this pull request to the merge queue Feb 27, 2026
Merged via the queue into rouge-ruby:main with commit 56751d2 Feb 27, 2026
10 checks passed
@larouxn larouxn deleted the rake_style_force_exclusion branch February 27, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants