Skip to content

console lexer: Limit number of prompt strings to 20 #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jneen wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

console lexer: Limit number of prompt strings to 20 #2268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ Rouge/NoBuildingAlternationPatternInRegexp:
- 'lib/rouge/lexers/bicep.rb'
- 'lib/rouge/lexers/cfscript.rb'
- 'lib/rouge/lexers/cmhg.rb'
- 'lib/rouge/lexers/console.rb'
- 'lib/rouge/lexers/crystal.rb'
- 'lib/rouge/lexers/csharp.rb'
- 'lib/rouge/lexers/d.rb'
Expand Down
6 changes: 5 additions & 1 deletion lib/rouge/lexers/console.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def comment_regex

def end_chars
@end_chars ||= if @prompt.any?
@prompt.reject { |c| c.empty? }
@prompt.reject { |c| c.empty? }.uniq.first(20)
elsif allow_comments?
%w($ > ;)
else
Expand Down Expand Up @@ -173,9 +173,13 @@ def prompt_prefix_regex
end

def prompt_regex
# [jneen] these characters can come from user input. They are escaped here,
# and we limit the user to 20.
#rubocop:disable Rouge/NoBuildingAlternationPatternInRegexp
@prompt_regex ||= begin
/^#{prompt_prefix_regex}(?:#{end_chars.map { |c| Regexp.escape(c) }.join('|')})/
end
#rubocop:enable Rouge/NoBuildingAlternationPatternInRegexp
end

def stream_tokens(input, &output)
Expand Down
⚡