Skip to content

Differentiate between optional and default groups in environments#2633

Merged
ppisar merged 5 commits intorpm-software-management:mainfrom
pkratoch:environment-default-groups
Mar 30, 2026
Merged

Differentiate between optional and default groups in environments#2633
ppisar merged 5 commits intorpm-software-management:mainfrom
pkratoch:environment-default-groups

Conversation

@pkratoch
Copy link
Copy Markdown
Contributor

@pkratoch pkratoch requested a review from a team as a code owner February 26, 2026 14:45
@pkratoch pkratoch requested review from ppisar and removed request for a team February 26, 2026 14:45
@ppisar ppisar self-assigned this Feb 27, 2026
@ppisar
Copy link
Copy Markdown
Contributor

ppisar commented Feb 27, 2026

The code looks good. But because it can only be merged after getting the support into libsolv, I recommend you turning this pull request into draft until libsolv is fixed.

@pkratoch pkratoch marked this pull request as draft February 27, 2026 14:50
@pkratoch pkratoch marked this pull request as ready for review March 10, 2026 14:01
@pkratoch pkratoch force-pushed the environment-default-groups branch from 69ebc5c to 806bebe Compare March 17, 2026 13:12
@pkratoch
Copy link
Copy Markdown
Contributor Author

Rebased and bumped required libsolv version.

Copy link
Copy Markdown
Contributor

@ppisar ppisar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, the code looks good.

I also tried dnf5 --no-plugins --repo rawhide --setopt 'install_weak_deps=True' environment info kde-desktop-environment to see whether I get firefox group ID listed (as suggested in the Fedora bug report), but I did not get it. Is that expected? I can see that this pull request only adds the very bare minimum without any attempt to enhance a user interface. But not seeing default=yes group ID in Optional groups section seems strange.

@pkratoch pkratoch force-pushed the environment-default-groups branch from 806bebe to fac37ac Compare March 26, 2026 15:11
@pkratoch
Copy link
Copy Markdown
Contributor Author

I first thought I would only add the default/optional distinction and then deal with the actual installation, but since I chose at the end not to include the default groups among the optional ones, it must be processed right away (as you also found out by trying out the info command). Therefore, I have added new commits for installing and upgrading also the default groups and for changing the output of the info command.

There is a change in behavior, as dnf previously didn't install the default groups, but it's in line with Anaconda's behavior. I didn't find any mention of this in the documentation, so I will also update that.

@pkratoch pkratoch force-pushed the environment-default-groups branch from fac37ac to 1581916 Compare March 26, 2026 15:31
Copy link
Copy Markdown
Contributor

@ppisar ppisar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it can list the default group and install it. But is it correct to install a default group if I use --setopt install_weak_deps=False? My understanding of default groups is that it's like a list of recommended packages.

I will merge this pull request because it's already big enough and it fixes the basic problem that default groups were completely ignored. If you think that default groups should be subject of install_weak_deps, feel free to supply next pull request.

@ppisar ppisar added this pull request to the merge queue Mar 30, 2026
Merged via the queue into rpm-software-management:main with commit ca7e148 Mar 30, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants