Differentiate between optional and default groups in environments#2633
Conversation
|
The code looks good. But because it can only be merged after getting the support into libsolv, I recommend you turning this pull request into draft until libsolv is fixed. |
69ebc5c to
806bebe
Compare
|
Rebased and bumped required libsolv version. |
ppisar
left a comment
There was a problem hiding this comment.
Otherwise, the code looks good.
I also tried dnf5 --no-plugins --repo rawhide --setopt 'install_weak_deps=True' environment info kde-desktop-environment to see whether I get firefox group ID listed (as suggested in the Fedora bug report), but I did not get it. Is that expected? I can see that this pull request only adds the very bare minimum without any attempt to enhance a user interface. But not seeing default=yes group ID in Optional groups section seems strange.
806bebe to
fac37ac
Compare
|
I first thought I would only add the default/optional distinction and then deal with the actual installation, but since I chose at the end not to include the default groups among the optional ones, it must be processed right away (as you also found out by trying out the info command). Therefore, I have added new commits for installing and upgrading also the default groups and for changing the output of the info command. There is a change in behavior, as dnf previously didn't install the default groups, but it's in line with Anaconda's behavior. I didn't find any mention of this in the documentation, so I will also update that. |
fac37ac to
1581916
Compare
ppisar
left a comment
There was a problem hiding this comment.
Now it can list the default group and install it. But is it correct to install a default group if I use --setopt install_weak_deps=False? My understanding of default groups is that it's like a list of recommended packages.
I will merge this pull request because it's already big enough and it fixes the basic problem that default groups were completely ignored. If you think that default groups should be subject of install_weak_deps, feel free to supply next pull request.
ca7e148
Requires: openSUSE/libsolv#607
Related: http://bugzilla.redhat.com/show_bug.cgi?id=2437049