Feature/con 194 js - copyright updates and add logging section#53
Feature/con 194 js - copyright updates and add logging section#53
Conversation
|
Do any of these issues need to be fixed
|
| All rights reserved. |br| | ||
| Printed in U.S.A. First printing. |br| | ||
| November 2019. |br| | ||
| April 2021. |br| |
There was a problem hiding this comment.
I thought we only updated the (c) year when the product changed in a major fashion, but not for normal releases.
| The security features of this product include software developed by the | ||
| OpenSSL Project for use in the OpenSSL Toolkit (http://www.openssl.org/). | ||
| OpenSSL Project for use in the OpenSSL Toolkit (http://www.openssl.org/). | ||
| his product includes cryptographic software written by Eric Young |
There was a problem hiding this comment.
| his product includes cryptographic software written by Eric Young | |
| This product includes cryptographic software written by Eric Young |
However, Connector doesn't include any security features, Connext Pro does.
There was a problem hiding this comment.
@alexcamposruiz, what do you recommend here? Should I delete the whole "The security features of this product ..." paragraph (keep in mind it was there even in 1.0.0, although without my additions here)?
According to Legal, the sentences I added have to accompany that first sentence from now on, and I have made that change in all products. Per Legal, it's OK if the product doesn't even use security features, having it there "just in case" or even when not needed is OK, in order to product just one copyright statement that works for all books.
Given that, we could, for Connector:
- delete the whole paragraph since Connector doesn't have security features
- keep it since it interoperates with Pro, which can use security features
- rewrite it to say something like, "The security features of RTI Connext include ..." if it just feels too strange to include this statement for Connector (I would want to run that by Legal, though)
There was a problem hiding this comment.
It makes sense to keep it so we have a single copyright statement.
@samuelraeburn can you look into these issues? |
|
(Responses inline)
See attached screenshot, the links in that google doc are dead now, but for me locally all classes are built for both APIs. Can you check if it is still an issue with the latest doc builds?
It does affect Connector, but I think I already fixed it. Have you found some instances of participant_qos that I have missed?
I have committed this change to this branch |
3 participants
No description provided.