Clean up stale development configuration#420
Merged
Merged
Conversation
cmd.exe does not strip single quotes, so glob patterns like 'src/**/*.ts' were passed to eslint and prettier verbatim and matched nothing. Double quotes are handled by both cmd.exe and POSIX shells, and neither expands the glob inside them, so the tools keep doing their own pattern expansion as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Nobody on this project uses nvm anymore. Inline the Node version into the two workflows that referenced the file via node-version-file, keeping Node 20 as-is until the planned upgrade to 22 and 24. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The filenamesPlugin and importPlugin namespaces are not registered by eslint-plugin-github 6 flat configs, which expose these plugins as import, eslint-comments, and i18n-text. The entries referencing them were leftovers from the eslint 9 migration in 420f3a6 and were silently ignored because they were set to off. Also drop the stale ecmaVersion setting, which the TypeScript parser overrides anyway. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Drop the option descriptions copied from an old tsc --init template and the explicit noImplicitAny, which strict already implies. No change in compiler behavior; dist/ is unchanged after a rebuild. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR removes stale development configuration and normalizes cross-platform tooling behavior (especially for Windows), while keeping the project’s intentional Node 20 baseline.
Changes:
- Updated
package.jsonscripts to use double quotes for glob patterns sonpm run lint/npm run formatwork on Windows. - Removed obsolete
.nvmrcusage by hardcoding Node 20 in workflows. - Cleaned up legacy/unused config noise in
eslint.config.mjsandtsconfig.json.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Removes template comments and redundant options while preserving current compiler behavior (strict, ES6 target). |
package.json |
Fixes Windows script execution by switching glob quoting to double quotes. |
eslint.config.mjs |
Removes stale parser/rule entries that were unused/ignored under the current flat config setup. |
.nvmrc |
Deletes unused Node version file now that workflows specify Node directly. |
.github/workflows/compile-dependabot-updates.yml |
Switches from node-version-file to explicit node-version: '20'. |
.github/workflows/check-dist.yml |
Switches from node-version-file to explicit node-version: '20'. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jun 12, 2026
Closed
hsbt
added a commit
that referenced
this pull request
Jun 12, 2026
The .nvmrc file these workflows used to read the Node version from was removed in #420, so the version is written into the setup-node steps directly. Keep it in sync with the node24 runtime the action declares. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up several pieces of stale development configuration that had accumulated from the original action template and past migrations.
The npm scripts used single quotes around glob patterns, which cmd.exe passes through verbatim, so
npm run lintandnpm run formatfailed on Windows. Double quotes behave the same as single quotes here on POSIX shells (the glob is not expanded either way and eslint/prettier resolve the pattern themselves), so switching to them makes the scripts work on both platforms without changing behavior on Linux CI..nvmrcis gone since nobody on this project uses nvm anymore. The two workflows that referenced it vianode-version-filenow specifynode-version: '20'directly. The Node version itself is intentionally left at 20; upgrading to 22 and then 24 will be done separately.eslint.config.mjscarried leftovers from the eslint 9 migration (420f3a6): rule entries under thefilenamesPluginandimportPluginnamespaces, which eslint-plugin-github 6 flat configs do not register (they exposeimport,eslint-comments, andi18n-textinstead). These entries were set to off and silently ignored. The staleecmaVersionparser option is also dropped, as the TypeScript parser overrides it.tsconfig.jsonloses the option descriptions copied from an oldtsc --inittemplate and the explicitnoImplicitAny, whichstrictalready implies.target: es6is kept for now and can be raised together with the Node upgrade. A fullnpm run allpasses anddist/is unchanged after rebuilding.🤖 Generated with Claude Code