Fix issues when a config.rb file is present somewhere in the directories#281
Merged
plusjade merged 2 commits intoruhoh:masterfrom Mar 29, 2014
Merged
Fix issues when a config.rb file is present somewhere in the directories#281plusjade merged 2 commits intoruhoh:masterfrom
config.rb file is present somewhere in the directories#281plusjade merged 2 commits intoruhoh:masterfrom
Conversation
…ories In this case the `config.yml` or `config.json` files might not get parsed, resulting in missing configuration
Contributor
Author
|
It seems it also fixes the issue with the |
Contributor
Author
|
Ah, found a bug with loading the config files from the subdirectories. Fixed and added tests for it |
plusjade
added a commit
that referenced
this pull request
Mar 29, 2014
Fix issues when a `config.rb` file is present somewhere in the directories
Member
|
@sztupy much appreciated! Sorry I haven't been around lately and it has taken me a while to merge this in. |
This was referenced Jun 17, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this case the
config.ymlorconfig.jsonfiles might not get parsed, resulting in missing configuration values, and/or errors