This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Use cfg(fuzzing) instead of a fuzztarget feature and don't allow 0-hashes.#111
Merged
apoelstra merged 3 commits intorust-bitcoin:masterfrom Mar 12, 2021
Merged
Use cfg(fuzzing) instead of a fuzztarget feature and don't allow 0-hashes.#111apoelstra merged 3 commits intorust-bitcoin:masterfrom
apoelstra merged 3 commits intorust-bitcoin:masterfrom
Conversation
Its harder to misuse an explicit cfg flag than a feature flag, and the rust-fuzzing ecosystem already sets the `fuzzing` cfg for us.
This prevents downstream software that wishes to use SHA256 output as private keys from needing to handle the 0-hash case explicitly.
sgeisler
approved these changes
Feb 20, 2021
apoelstra
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-bitcoin/rust-secp256k1#264 starts enforcing that 32 bytes of 0s is an invalid private key in fuzzing, which breaks downstream applications which don't bother to check for the sha256-is-broken case. rust-bitcoin/rust-secp256k1#282 keeps that behavior, so best to no longer return 0 hashes from sha256 at all. We also update to use the new fuzzing cfg which is nicer anyway.