Remove unused Option en/decoding#236
Merged
dongcarl merged 1 commit intorust-bitcoin:masterfrom Feb 22, 2019
Merged
Conversation
stevenroose
approved these changes
Feb 21, 2019
sgeisler
approved these changes
Feb 21, 2019
Contributor
There was a problem hiding this comment.
Since this changes the public interface: are you sure that nothing outside this library depends on this impl?
Thinking about it there shouldn't be a valid use case since all protocol related data structures should be in rust-bitcoin. The only other place I would expect it to be used would be rust-elements, but I couldn't find code depending on it.
I think @apoelstra should have a look at it.
Member
|
Agreed with @sgeisler, we might as well remove this. |
apoelstra
approved these changes
Feb 22, 2019
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
Thresh bug with equal verify
PastaPastaPasta
pushed a commit
to PastaPastaPasta/rust-dashcore
that referenced
this pull request
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175