Conversation
773c5e0 to
90cb108
Compare
|
Now includes version bump, please see #40 for discussion on the version format. |
abb7c80 Bump version 0.10.0 -> 0.11.0 (Tobin Harding) b270023 Update to use edition 2018 (Tobin Harding) e762962 Update MSRV in CI and Readme from 1.29 to 1.41.1 (Tobin Harding) 3602c75 Remove trailing whitespace (Tobin Harding) Pull request description: Update the MSRV to Rustn 1.41.1 and enable edition 2018. Should not be merged without rust-bitcoin organization-wide planning on how to go about this upgrade. Discussion: rust-bitcoin/rust-bitcoin#510 (comment) This one is a bit more involved than the same PRs for [rust-bech32](rust-bitcoin/rust-bech32#57) or [rust-bitcoinconcensus](rust-bitcoin/rust-bitcoinconsensus#34). The commit message of patch 3: ``` Update to use edition 2018 Add `edition = "2018"` to the minifest file. In order to get the codebase to build cleanly do: - Remove usage of `use Hash as HashTrait`, instead use `impl crate::Hash for Hash` and `use Hash as _`. - Same for HashEngine (remove EngineTrait). - Add `crate::` to import statements and group same level (only did this for crate imports, the rest can wait for rustfmt :) - Make test imports uniform, elect to _not_ use `super::*` because it seems cleaner, we are always importing the module we are testing and the same set of traits in each `test` module. Can change if requested. ``` Thanks ACKs for top commit: apoelstra: ACK abb7c80 Tree-SHA512: 6e99235075a12a82bc2bb032411eb7d022c650e5288bd1a2891b3d863e093ad9398525c1fba41d5e3fdcb194fcf93b00c6f59ad7681f5404eaeae73f08af2278
|
Changes in force-push: rebase on master ignoring old appveyor config file, no other changes. |
Done in preparation for updating the MSRV across all the rust-bitcoin crates. For discussion see: rust-bitcoin/rust-bitcoin#510 (comment)
Add `edition = 2018` to the manifest file. No further changes were necessary to get the code to lint cleanly.
|
... and fix up github actions CI job. |
|
@tcharding are you able to merge this? I'm getting a weird error message from the merge script. |
We recently bumped the MSRV, this is a major change and requires a version bump. We are using a version format that includes the Bitcoin Core version and the version for this lib, currently the lib version is a single number. Instead use typical semvar <Major>.<Minor>.<Patch> for the lib.
|
Please note I made a change to the PR (I wanted to force push to run CI without AppVeyor) Version is now |
|
My first try merging using the merge script. I had to hack it to skip |
|
Update the MSRV to Rust 1.41.1 and enable edition 2018.
Should not be merged without rust-bitcoin organization-wide planning on how to go about this upgrade.
Leaving as draft until rust-bitcoin Taproot release is done.Discussion: rust-bitcoin/rust-bitcoin#510 (comment)