Closed
Conversation
Member
Author
|
Okay, I have investigated this for a couple of hours. Giving up on this, any ideas appreciated. Maybe it was some random bug in one of the dependencies? |
Member
Author
|
Well, now it's passing again. But this is flaky and should be investigated |
Member
|
Closing this, we realized that the issue was caused by the rust-secp "fuzztarget" crypto being broken. See rust-bitcoin/rust-secp256k1#264 where I fixed it and rust-bitcoin/rust-secp256k1#282 where Matt re-broke it to improve fuzzability. I put fixing this on my list of potential intern jobs, it's not trivial to get internally consistent crypto which can still be broken by a fuzzer and which has similar parser behavior to the real libsecp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unable to replicate the crash from https://github.com/rust-bitcoin/rust-miniscript/runs/3041068605 locally. Creating a upstream to retest the same vector on CI