Open
Conversation
Collaborator
|
Hi relnotes-interest-group, this PR adds a release blog post. Could you review cc @alex-semenyuk @jieyouxu @joshtriplett @lcnr @traviscross |
Mark-Simulacrum
commented
Apr 8, 2026
Mark-Simulacrum
commented
Apr 8, 2026
Comment on lines
+70
to
+72
| Note that the compiler will not currently consider the patterns matched in `if | ||
| let` guards as part of the exhaustiveness evaluation of the overall match, just | ||
| like `if` guards. |
Member
Author
There was a problem hiding this comment.
I don't know if this is worth calling out explicitly. I was actually half-expecting that this does participate in exhaustiveness analysis (it seems like we could make it do that, for the case where the RHS of the if let is a value from the match's expression).
I'm guessing our mental model is that these are 'just' guards though in which case the implemented behavior makes sense. If so, maybe we should strike 'currently' from this text.
shepmaster
reviewed
Apr 8, 2026
Co-authored-by: Jake Goulding <shepmaster@mac.com>
jieyouxu
reviewed
Apr 9, 2026
alex-semenyuk
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rustbot ping relnotes-interest-group
cc @rust-lang/release
Rendered