Add support for recognizing some architectures supported by GCC, but not LLVM.#1500
Merged
NobodyXu merged 1 commit intorust-lang:mainfrom Jul 26, 2025
Merged
Add support for recognizing some architectures supported by GCC, but not LLVM.#1500NobodyXu merged 1 commit intorust-lang:mainfrom
NobodyXu merged 1 commit intorust-lang:mainfrom
Conversation
FractalFir
force-pushed
the
main
branch
5 times, most recently
from
525f9f4 to
98252af
Compare
11 tasks
NobodyXu
reviewed
Jul 25, 2025
|
|
||
| // Arches supported by gcc, but not LLVM. | ||
| arch if arch.starts_with("alpha") => "alpha", // DEC Alpha | ||
| "parisc" => "parisc", // https://en.wikipedia.org/wiki/PA-RISC, also known as HPPA |
Contributor
There was a problem hiding this comment.
I googled and can't find any target with parisc name in it https://parisc.docs.kernel.org/en/latest/binutils.html
For PA-RISC, binutils supports several targets, including hppa-linux, hppa64-linux, hppa-netbsd, hppa-hpux, hppa64-hpux.
Contributor
Author
There was a problem hiding this comment.
Sorry, my bad. I got deceived by some GCC config options, which call this ISA parisc instead of hppa.
The correct name seems to be indeed hppa.
Contributor
Author
|
Fixed the incorrect naming("parisc" -> "hppa"). |
NobodyXu
approved these changes
Jul 26, 2025
Contributor
NobodyXu
left a comment
NobodyXu
left a comment
There was a problem hiding this comment.
Thanks, LGTM, the next scheduled release is on next Thursday/Friday, do you want a new release now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for parsing targets with architectures supported by GCC, but not LLVM.
I am currently working on adding support for those architectures to
rustc_codegen_gcc. Adding full support for those architectures would allow Rust packages to be built for all the platforms debian supports.Since
alphaand SuperH(sh) have multiple variants, I usestarts_withto detect them, as seems to be the convention.The GCC config does not mention any variants of
parisc, so I just match on that strict.