libc: remove TIOCMGDTRWAIT and TIOCMSDTRWAIT for freebsd15#4685
libc: remove TIOCMGDTRWAIT and TIOCMSDTRWAIT for freebsd15#4685tgross35 merged 1 commit intorust-lang:mainfrom
Conversation
|
This fixes the error in freebsd15 related to these constants, so that we now get the same issue as #4651. Since fixing it is being actively worked on in rust-lang/rust#134697, eventually freebsd15 will fix itself. |
asomers
left a comment
There was a problem hiding this comment.
Those ioctls have been unused since FreeBSD 8. So you should remove them entirely, rather than just for freebsd 15 builds. Since this PR targets the main branch, backwards-compatibility concerns are relaxed.
When applying this change to the libc-0.2 branch, we should mark the symbols as deprecated, rather than removing them.
|
Also, you should avoid removing the symbols from DragonflyBSD builds, if that was not your intention. |
07283e6 to
f96a9e1
Compare
f96a9e1 to
f15031e
Compare
f15031e to
830b748
Compare
|
For future reference, it's a bit easier to just deprecate things on It will be easy to find+delete everything that's deprecated just before the 1.0 release, whenever that is. |
These constants were removed on `main` in ec605ff ("libc: fix ctest failure on freebsd15"). Mark them as deprecated with 0.2 rather than removing directly. Effectively a backport of rust-lang#4685.
These constants were removed on `main` in ec605ff ("libc: fix ctest failure on freebsd15"). Mark them as deprecated with 0.2 rather than removing directly. Effectively a backport of rust-lang#4685.
These constants were removed on `main` in ec605ff ("libc: fix ctest failure on freebsd15"). Mark them as deprecated with 0.2 rather than removing directly. Effectively a backport of rust-lang#4685.
These constants were removed on `main` in ec605ff ("libc: fix ctest failure on freebsd15"). Mark them as deprecated with 0.2 rather than removing directly. Effectively a backport of rust-lang#4685.
These constants were removed on `main` in ec605ff ("libc: fix ctest failure on freebsd15"). Mark them as deprecated with 0.2 rather than removing directly. Effectively a backport of rust-lang#4685.
Description
FreeBSD 15 removed
TIOCMGDTRWAITandTIOCMSDTRWAIT, so the corresponding constants are changed to only appear in FreeBSD 13 and 14 builds.Sources
freebsd/freebsd-src@4b4cf0d
https://cgit.freebsd.org/src/commit/?id=4b4cf0d52c43e33c32983df60a8ea16b3d9e2f20
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI