Update dependencies & fix GitHub commit signing#104
Merged
emilyalbini merged 3 commits intorust-lang:masterfrom Apr 6, 2026
Merged
Update dependencies & fix GitHub commit signing#104emilyalbini merged 3 commits intorust-lang:masterfrom
emilyalbini merged 3 commits intorust-lang:masterfrom
Conversation
This fixes a longstanding bug with GitHub tag signing where the timestamp of the created tag would differ from the signature, causing failed signature verification.
emilyalbini
reviewed
Apr 6, 2026
emilyalbini
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps to latest pgp/rsa/sha2 crates, finishing the update from #103. We still depend on an old rand due to pgp having a stale dependency.
This also adds unit test coverage for the signing flow outside the full integration tests, helping with local testing. As part of adding those tests it identified a bug in the Git tag signing flow (existing since it was added in 2022) which should be fixed by the last commit.