Really stop recompressing to-be-pruned artifacts#105
Merged
emilyalbini merged 1 commit intorust-lang:masterfrom Apr 9, 2026
Merged
Really stop recompressing to-be-pruned artifacts#105emilyalbini merged 1 commit intorust-lang:masterfrom
emilyalbini merged 1 commit intorust-lang:masterfrom
Conversation
This was added as a temporary measure in a226029 because otherwise build-manifest failed to read version information, which resulted in the packages getting dropped. As of the mentioned PR (rust-lang/rust#110436) this is no longer an issue, and that PR has long reached all branches. Empirically, we see in build metrics that nightly releases take around 1h50m, while beta and stable releases take above 3 hours. This is largely explained by extra recompression done in beta/stable releases today of files that subsequently are deleted in `prune_unused_files`. This also avoids having different code paths on different channels, which seems like a good win no matter what.
emilyalbini
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added as a temporary measure in a226029 because otherwise build-manifest failed to read version information, which resulted in the packages getting dropped. As of the mentioned PR (rust-lang/rust#110436) this is no longer an issue, and that PR has long reached all branches.
Empirically, we see in build metrics that nightly releases take around 1h50m, while beta and stable releases take above 3 hours. This is largely explained by extra recompression done in beta/stable releases today of files that subsequently are deleted in
prune_unused_files.This also avoids having different code paths on different channels, which seems like a good win no matter what.