Update manifests.txt from the release process#89
Merged
emilyalbini merged 2 commits intomasterfrom Jul 1, 2025
Merged
Conversation
Mark-Simulacrum
approved these changes
Jul 1, 2025
Member
Mark-Simulacrum
left a comment
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
This seems okay. I'm a little unhappy that it moves the generation from being idempotent to stateful, but that seems overall OK for the purposes of this file... and if we ever run into issues it can be manually edited or re-generated, too.
This was referenced Jul 1, 2025
| .args(["--key", "manifests.txt"]) | ||
| // Fail the request if the manifest was already modified by something else (for | ||
| // example, another release running in parallel). | ||
| .args(["--if-none-match", &if_none_match]))?; |
Member
There was a problem hiding this comment.
Looking at this again, shouldn't this be if-match with the etag value? I'm not sure that if-none-match $etag actually works...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now https://static.rust-lang.org/manifests.txt is uploaded by generate-manifest-list, in a cron running every week. This is an extra bit of infrastructure to maintain and means the list is often out of date.
This PR moves updating manifests.txt to the release process. Once it's merged we can retire the old tool.
Since multiple release processes can run at the same time, there is a chance they'd try to update manifests.txt at the same time, potentially overriding each other's work. To avoid that I use conditional writes in a retry loop.